Skip to content

Generate unified landing page with links to indiv. rank reports #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

skarjala
Copy link
Contributor

@skarjala skarjala commented Jul 8, 2025

Summary:

  • Add TEMPLATE_MULTI_RANK_INDEX template
  • Generate unified landing page with links to individual rank reports

@skarjala skarjala marked this pull request as draft July 9, 2025 20:43
@skarjala skarjala marked this pull request as ready for review July 9, 2025 20:52
@skarjala skarjala marked this pull request as draft July 9, 2025 22:31
@skarjala skarjala marked this pull request as ready for review July 10, 2025 16:57
@xmfan
Copy link
Member

xmfan commented Jul 10, 2025

This is quite difficult to review, because it contains the changes from your previous PR. You could point your base (pytorch:main) to your previous PR's branch (skarjala:pr1-core-logic). But I would just recommend to focus on addressing all comments of the previous one first, and putting this one on hold.

@skarjala skarjala marked this pull request as draft July 10, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants